Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions should receive stop button event #706

Open
ericrosenbaum opened this issue Oct 11, 2017 · 1 comment
Open

Extensions should receive stop button event #706

ericrosenbaum opened this issue Oct 11, 2017 · 1 comment
Assignees
@ericrosenbaum @cwillisf
Labels
bug extensions
Milestone
Backlog

Comments

@ericrosenbaum
Copy link
Contributor

Expected Behavior

If a Lego motor is running, you should be able to stop it by pressing the stop button.

Generally, extensions should have a function that gets called on the stop event.

Actual Behavior

The stop button is not yet hooked up to extensions.
@ericrosenbaum ericrosenbaum added this to the Oct 18 milestone Oct 11, 2017
@cwillisf cwillisf modified the milestones: Oct 18, Jan 24 Oct 25, 2017
@ericrosenbaum ericrosenbaum changed the title Stop button should stop all Lego WeDo motors Extensions should receive stop button event Nov 9, 2017
@thisandagain
Copy link
Contributor

thisandagain commented Dec 20, 2017 •
edited
Loading

@ericrosenbaum My instinct is to not label this as critical (blocking release) because the play note blocks now have a limit on them. Do you agree?

@thisandagain thisandagain modified the milestones: January, Backlog Dec 21, 2017
@towerofnix towerofnix mentioned this issue Apr 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericrosenbaum ericrosenbaum

@cwillisf cwillisf

Labels
bug extensions
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@ericrosenbaum @thisandagain @cwillisf