Skip to content

Commit 164e58e

Browse files
authored
Merge pull request #4177 from LLK/release/2020-07-08
[Master] Release 2020-07-08
2 parents 5a09f9c + e5d2fd6 commit 164e58e

File tree

11 files changed

+312
-291
lines changed

11 files changed

+312
-291
lines changed

package-lock.json

Lines changed: 272 additions & 272 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@
128128
"redux-mock-store": "^1.2.3",
129129
"redux-thunk": "2.0.1",
130130
"sass-loader": "6.0.6",
131-
"scratch-gui": "0.1.0-prerelease.20200622200348",
131+
"scratch-gui": "0.1.0-prerelease.20200708034512",
132132
"scratch-l10n": "latest",
133133
"selenium-webdriver": "3.6.0",
134134
"slick-carousel": "1.6.0",

src/components/join-flow/username-step.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class UsernameStep extends React.Component {
3434
};
3535
// simple object to memoize remote requests for usernames.
3636
// keeps us from submitting multiple requests for same data.
37-
this.usernameRemoteCache = {};
37+
this.usernameRemoteCache = Object.create(null);
3838
}
3939
componentDidMount () {
4040
// Send info to analytics when we aren't on the standalone page.
@@ -58,7 +58,7 @@ class UsernameStep extends React.Component {
5858
}
5959
// simple function to memoize remote requests for usernames
6060
validateUsernameRemotelyWithCache (username) {
61-
if (this.usernameRemoteCache.hasOwnProperty(username)) {
61+
if (typeof this.usernameRemoteCache[username] === 'object') {
6262
return Promise.resolve(this.usernameRemoteCache[username]);
6363
}
6464
// username is not in our cache

src/components/modal/addtostudio/modal.scss

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,8 @@
3434
background-color: $ui-blue-10percent;
3535
flex: 1;
3636
height: calc(100% - 5rem);
37-
38-
@media #{$small-height} {
39-
min-height: 0;
40-
}
37+
/* Firefox requires min-height:0: #3775 */
38+
min-height: 0;
4139
}
4240

4341
.studio-list-inner-scrollbox {

src/lib/decorate-text.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ module.exports = (text, opts) => {
2424
if (opts.usernames) {
2525
replacedText = reactStringReplace(replacedText, /@([\w-]+)/g, (match, i) => (
2626
<a
27-
href={`/users/${match}`}
27+
href={match.toLowerCase() === 'welcomingcommittee' ? '/studios/146521/' : `/users/${match}`}
2828
key={match + i}
2929
>@{match}</a>
3030
));

src/routes.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -434,6 +434,12 @@
434434
"routeAlias": "/info/?(\\?.*)?$",
435435
"redirect": "/ideas"
436436
},
437+
{
438+
"name": "register-redirect",
439+
"pattern": "^/accounts/standalone-registration/?$",
440+
"routeAlias": "/accounts/standalone-registration/",
441+
"redirect": "/join"
442+
},
437443
{
438444
"name": "research-redirect",
439445
"pattern": "^/info/research/?$",

src/views/credits/credits.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ const Credits = () => (
109109
id="credits.acknowledgementsTranslators"
110110
values={{
111111
translatorsLink: (
112-
<a href="http://wiki.scratch.mit.edu/wiki/Translators">
112+
<a href="https://en.scratch-wiki.info/wiki/Translators">
113113
<FormattedMessage id="credits.acknowledgementsTranslatorsLinkText" />
114114
</a>
115115
)
@@ -151,8 +151,8 @@ const Credits = () => (
151151
{' '}
152152
Ben Berg, Amos Blanton, Karen Brennan, Juanita Buitrago,
153153
Leo Burd, Gaia Carini, Kasia Chmielinski, Michelle Chung,
154-
Shane Clements, Hannah Cole, Ellen Daoust, Sayamindu Dasgupta,
155-
Margarita Dekoli, Dave Feinberg, Linda Fernsel,
154+
Shane Clements, Hannah Cole, Sayamindu Dasgupta,
155+
Margarita Dekoli, Dave Feinberg, Linda Fernsel, Elizabeth Foster,
156156
Chris Graves, Joel Gritter, Megan Haddadi, Connor Hudson,
157157
Christina Huang, Tony Hwang, Abdulrahman Idlbi, Randy Jou,
158158
Lily Kim, Tauntaun Kim, Saskia Leggett, Tim Mickel,

src/views/credits/people.json

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
[
2+
{
3+
"userName": "originalwow",
4+
"userId": 56182496,
5+
"name": "Amielle"
6+
},
27
{
38
"userName": "amylaser",
49
"userId": 17462181,
@@ -53,9 +58,14 @@
5358
"userName": "codubee",
5459
"userId": 10866958,
5560
"name": "Colby"
61+
},
62+
{
63+
"userName": "noncanonical",
64+
"userId": 55851826,
65+
"name": "Craig"
5666
},
5767
{
58-
"userName": "harakou",
68+
"userName": "Harakou",
5969
"userId": 373646,
6070
"name": "Dalton"
6171
},
@@ -65,9 +75,9 @@
6575
"name": "DD"
6676
},
6777
{
68-
"userName": "rmiel",
69-
"userId": 34557192,
70-
"name": "Elizabeth"
78+
"userName": "SunnyDay4aBlueJay",
79+
"userId": 24164779,
80+
"name": "Ellen"
7181
},
7282
{
7383
"userName": "ericr",
@@ -104,6 +114,11 @@
104114
"userId": 2496866,
105115
"name": "Jolie"
106116
},
117+
{
118+
"userName": "Class12321",
119+
"userId": 2871308,
120+
"name": "Joshua"
121+
},
107122
{
108123
"userName": "bluecrazie",
109124
"userId": 50257624,

src/views/download/l10n.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,6 @@
5050
"download.whyAskForLocation" : "Why is {operatingsystem} asking for my location?",
5151
"download.whyAskForLocationAnswer" : "Scratch uses bluetooth to connect to other devices, such as a micro:bit or LEGO BOOST. Bluetooth can be used to provide location data to the app, so Google requires every app that uses bluetooth ask users for permission to access their location. Scratch will not use bluetooth to track your location.",
5252
"download.whereProjectStored" : "Where does the Scratch App store my projects?",
53-
"download.whereProjectStoredAnswer" : "Projects are saved internally in the app. To export a project file, click the 3-dot menu and select \"Share\". On the next screen select \"export\". The options visible depend on the applications installed on your device. Common options are Google Drive, Files, and email."
53+
"download.whereProjectStoredAnswer" : "Projects are saved internally in the app. To export a project file, click the 3-dot menu and select \"Share\". On the next screen select \"export\". The options visible depend on the applications installed on your device. Common options are Google Drive, Files, and email.",
54+
"download.iconAltText" : "Download"
5455
}

src/views/preview/preview.scss

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ $stage-width: 480px;
3838

3939
.inner {
4040
margin: 0 auto;
41-
overflow: auto;
4241

4342
@media #{$medium-and-smaller} {
4443
// subtract page padding
@@ -365,7 +364,7 @@ $stage-width: 480px;
365364
.guiPlayer {
366365
display: inline-block;
367366
position: relative;
368-
max-width: $player-width;
367+
width: $player-width;
369368
z-index: 1;
370369

371370
$alert-bg: rgba(255, 255, 255, .85);
@@ -402,6 +401,7 @@ $stage-width: 480px;
402401
flex: 1;
403402
flex-flow: column;
404403
margin-top: .3125rem;
404+
overflow: auto;
405405

406406
@media #{$medium-and-smaller} {
407407
margin-top: .5rem;
@@ -479,7 +479,6 @@ $stage-width: 480px;
479479
line-height: 1.5rem;
480480
flex: 1;
481481
overflow-wrap: break-word;
482-
word-break: break-word;
483482
}
484483

485484
.project-description:last-of-type {

0 commit comments

Comments
 (0)