Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build started by non-logged in user #90

Closed
FenrirUnbound opened this issue Aug 12, 2016 · 2 comments
Closed

Build started by non-logged in user #90

FenrirUnbound opened this issue Aug 12, 2016 · 2 comments

Comments

@FenrirUnbound
Copy link
Collaborator

Given a scenario where the user "Jer" is not logged in and has not authorized Screwdriver. When that user opens a PR, the API will complain about the user not existing in the ecosystem yet. This results in a 500 being returned by the server.

@stjohnjohnson
Copy link
Contributor

Wait, this shouldn't happen. It won't use Jer as the user to authenticate. It uses the person who setup the pipeline. It just logs that Jer starts the build.

https://github.com/screwdriver-cd/models/blob/786aaa957d522a2f82c8a2f811ba7e59dc7198f7/lib/buildFactory.js#L108

@stjohnjohnson
Copy link
Contributor

Unable to replicate this. We don't use the PR user, we use the pipeline user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants