Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for setting of pagination limit in SimplePaginatedList #21

Open
ctgraham opened this issue Oct 30, 2020 · 0 comments · May be fixed by #25
Open

Allow for setting of pagination limit in SimplePaginatedList #21

ctgraham opened this issue Oct 30, 2020 · 0 comments · May be fixed by #25

Comments

@ctgraham
Copy link
Contributor

SimplePaginatedList->limit is a protected property with a default value of 10 and no setter:

php-alma-client/src/Model/SimplePaginatedList.php

Line 19 in 536c67f

protected $limit = 10;

Legitimate values, for endpoints supporting the limit parameter, are 0 - 100.
ctgraham added a commit to ulsdevteam/php-alma-client that referenced this issue Oct 30, 2020
@ctgraham
scriptotek#21: add mutator for pagination limit
f6e6151
ctgraham added a commit to ulsdevteam/php-alma-client that referenced this issue Oct 30, 2020
@ctgraham
scriptotek#21: enforce typecast when setting pagination limit
5bc6097
ctgraham added a commit to ulsdevteam/php-alma-client that referenced this issue Oct 30, 2020
@ctgraham
scriptotek#21: root namespace for RuntimeException
866ee0b
ctgraham added a commit to ulsdevteam/php-alma-client that referenced this issue Nov 16, 2020
@ctgraham
scriptotek#21: Add setter for pagination of SimplePaginatedList
5915df1
@ctgraham ctgraham linked a pull request Nov 16, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scriptotek#21: Add setter for pagination of SimplePaginatedList ulsdevteam/php-alma-client
1 participant
@ctgraham