address review comments

Author: jonastheis

rollup/da_syncer/batch_queue.go

@@ -98,5 +98,6 @@ func (bq *BatchQueue) deleteBatch(batch da.Entry) {
 func (bq *BatchQueue) Reset(height uint64) {
 	bq.batches.Clear()
 	bq.batchesMap.Clear()
+	bq.lastFinalizedBatchIndex = 0
 	bq.DAQueue.Reset(height)
 }

rollup/da_syncer/blob_client/block_native_client.go

@@ -30,7 +30,11 @@ func (c *BlockNativeClient) GetBlobByVersionedHashAndBlockNumber(ctx context.Con
 	if err != nil {
 		return nil, fmt.Errorf("failed to join path, err: %w", err)
 	}
-	resp, err := http.Get(path)
+	req, err := http.NewRequestWithContext(ctx, "GET", path, nil)
+	if err != nil {
+		return nil, fmt.Errorf("cannot create request, err: %w", err)
+	}
+	resp, err := http.DefaultClient.Do(req)
 	if err != nil {
 		return nil, fmt.Errorf("cannot do request, err: %w", err)
 	}

rollup/da_syncer/da/commitV1.go

@@ -52,7 +52,7 @@ func NewCommitBatchDAWithBlob(ctx context.Context, db ethdb.Database,
 	// compute blob versioned hash and compare with one from tx
 	c, err := kzg4844.BlobToCommitment(blob)
 	if err != nil {
-		return nil, fmt.Errorf("failed to create blob commitment")
+		return nil, fmt.Errorf("failed to create blob commitment: %w", err)
 	}
 	blobVersionedHash := common.Hash(kzg4844.CalcBlobHashV1(sha256.New(), &c))
 	if blobVersionedHash != versionedHash {

rollup/da_syncer/da_queue.go

@@ -27,6 +27,12 @@ func NewDAQueue(l1height uint64, dataSourceFactory *DataSourceFactory) *DAQueue
 
 func (dq *DAQueue) NextDA(ctx context.Context) (da.Entry, error) {
 	for len(dq.da) == 0 {
+		select {
+		case <-ctx.Done():
+			return nil, ctx.Err()
+		default:
+		}
+
 		err := dq.getNextData(ctx)
 		if err != nil {
 			return nil, err

rollup/da_syncer/da_syncer.go

@@ -37,6 +37,10 @@ func (s *DASyncer) SyncOneBlock(block *da.PartialBlock) error {
 	}
 
 	parentBlock := s.blockchain.GetBlockByNumber(currentBlock.Number().Uint64())
+	if parentBlock == nil {
+		return fmt.Errorf("parent block not found at height %d", currentBlock.Number().Uint64())
+	}
+
 	if _, err := s.blockchain.BuildAndWriteBlock(parentBlock, block.PartialHeader.ToHeader(), block.Transactions); err != nil {
 		return fmt.Errorf("failed building and writing block, number: %d, error: %v", block.PartialHeader.Number, err)
 	}