snark-verifier test failed

[Velaciela]

recent dev branch (scroll-dev-1220) does not pass the tests in snark-verifier

by adding commit: [revert vanishing.commit to PSE's version] to branch: [pse_snark_verifier_test]
the proofs can be verified by two examples in the snark-verifier and pass default tests

@jonathanpwang @kunxian-xia @lispc

[Velaciela]

Here is another test from @kunxian-xia
If we change C::identity to C::generator, which writes point (1,2)
it can also pass evm-verifier

        // Sample a random polynomial of degree n - 1
        let mut random_poly = domain.empty_coeff();
        random_poly[0] = C::Scalar::one();
        // Sample a random blinding factor
        let random_blind = Blind(C::Scalar::zero());
        let c = C::generator();

[kunxian-xia]

Is it possible that the evm-verifier cannot handle the point at infinity properly?

[jonathanpwang]

Good find!

BTW for true no-zk option, we should try to merge privacy-scaling-explorations#76
snark-verifier should be able to support this once it's merged (most of the code is already there), due to @han0110.

[jonathanpwang]

Is it possible that the evm-verifier cannot handle the point at infinity properly?

@han0110 told me the evm-verifier does sanity checks for safety and specifically rejects point at infinity: https://github.com/privacy-scaling-explorations/snark-verifier/blob/main/snark-verifier/src/loader/evm/code.rs#L41-L62