Skip to content

Commit 4c5a1bf

Browse files
committed
fix: address comments
1 parent 66ebecf commit 4c5a1bf

File tree

4 files changed

+3
-5
lines changed

4 files changed

+3
-5
lines changed
File renamed without changes.
File renamed without changes.

database/migrate/migrations/00027_ blob_upload.sql

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@ CREATE INDEX IF NOT EXISTS idx_blob_upload_platform ON blob_upload(platform) WHE
2323

2424
CREATE INDEX IF NOT EXISTS idx_blob_upload_status ON blob_upload(status) WHERE deleted_at IS NULL;
2525

26-
CREATE INDEX IF NOT EXISTS idx_blob_upload_created_at ON blob_upload(created_at) WHERE deleted_at IS NULL;
27-
28-
CREATE INDEX IF NOT EXISTS idx_blob_upload_updated_at ON blob_upload(updated_at) WHERE deleted_at IS NULL;
29-
3026
CREATE INDEX IF NOT EXISTS idx_blob_upload_status_platform ON blob_upload(status, platform) WHERE deleted_at IS NULL;
3127

3228
CREATE INDEX IF NOT EXISTS idx_blob_upload_batch_index_status_platform ON blob_upload(batch_index, status, platform) WHERE deleted_at IS NULL;

rollup/internal/controller/blob_uploader/blob_uploader.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,9 @@ func (b *BlobUploader) constructBlobCodec(dbBatch *orm.Batch) (*kzg4844.Blob, er
154154
var encodingBatch *encoding.Batch
155155
codecVersion := encoding.CodecVersion(dbBatch.CodecVersion)
156156
switch codecVersion {
157-
case encoding.CodecV0, encoding.CodecV1, encoding.CodecV2, encoding.CodecV3, encoding.CodecV4, encoding.CodecV5, encoding.CodecV6:
157+
case encoding.CodecV0:
158+
return nil, fmt.Errorf("codec version 0 doesn't support blob, batch index: %d", dbBatch.Index)
159+
case encoding.CodecV1, encoding.CodecV2, encoding.CodecV3, encoding.CodecV4, encoding.CodecV5, encoding.CodecV6:
158160
encodingBatch = &encoding.Batch{
159161
Index: dbBatch.Index,
160162
TotalL1MessagePoppedBefore: dbChunks[0].TotalL1MessagesPoppedBefore,

0 commit comments

Comments
 (0)