Skip to content

Commit a434b2c

Browse files
yiweichicolinlyguo
andauthored
Apply suggestions from code review
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
1 parent 0570525 commit a434b2c

File tree

3 files changed

+3
-9
lines changed

3 files changed

+3
-9
lines changed

rollup/cmd/blob_uploader/app/app.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,10 @@ func init() {
3131
app.Usage = "The Scroll Blob Uploader"
3232
app.Version = version.Version
3333
app.Flags = append(app.Flags, utils.CommonFlags...)
34-
app.Flags = append(app.Flags, utils.RollupRelayerFlags...)
3534
app.Commands = []*cli.Command{}
3635
app.Before = func(ctx *cli.Context) error {
3736
return utils.LogSetup(ctx)
3837
}
39-
// Register `rollup-relayer-test` app for integration-test.
40-
utils.RegisterSimulation(app, utils.RollupRelayerApp)
4138
}
4239

4340
func action(ctx *cli.Context) error {

rollup/internal/controller/blob_uploader/blob_uploader_metrics.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,16 @@ var (
1717
blobUploaderMetric *blobUploaderMetrics
1818
)
1919

20-
func initblobUploaderMetrics(reg prometheus.Registerer) *blobUploaderMetrics {
20+
func initBlobUploaderMetrics(reg prometheus.Registerer) *blobUploaderMetrics {
2121
initBlobUploaderMetricsOnce.Do(func() {
2222
blobUploaderMetric = &blobUploaderMetrics{
2323
rollupBlobUploaderUploadToS3SuccessTotal: promauto.With(reg).NewCounter(prometheus.CounterOpts{
2424
Name: "rollup_blob_uploader_upload_to_s3_success_total",
25-
Help: "The total number of upload blob to S3 run success total",
25+
Help: "The total number of upload blob to S3 runs success total",
2626
}),
2727
rollupBlobUploaderUploadToS3FailedTotal: promauto.With(reg).NewCounter(prometheus.CounterOpts{
2828
Name: "rollup_blob_uploader_upload_to_s3_failed_total",
29-
Help: "The total number of upload blob to S3 run failed total",
29+
Help: "The total number of upload blob to S3 runs failed total",
3030
}),
3131
}
3232
})

rollup/internal/orm/blob_upload.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ func (o *BlobUpload) InsertBlobUpload(ctx context.Context, batchIndex uint64, pl
3737
BatchIndex: batchIndex,
3838
Platform: int16(platform),
3939
Status: int16(status),
40-
UpdatedAt: time.Now(),
4140
}
4241

4342
db := o.db
@@ -63,7 +62,6 @@ func (o *BlobUpload) UpdateBlobUploadStatus(ctx context.Context, batchIndex uint
6362

6463
updates := map[string]interface{}{
6564
"status": status,
66-
"updated_at": time.Now(),
6765
}
6866

6967
if err := db.Updates(updates).Error; err != nil {
@@ -83,7 +81,6 @@ func (o *BlobUpload) InsertOrUpdateBlobUpload(ctx context.Context, batchIndex ui
8381
BatchIndex: batchIndex,
8482
Platform: int16(platform),
8583
Status: int16(status),
86-
UpdatedAt: time.Now(),
8784
}
8885
if err := db.Clauses(clause.OnConflict{
8986
Columns: []clause.Column{{Name: "batch_index"}, {Name: "platform"}},

0 commit comments

Comments
 (0)