metric: add proving time (#170)

* upgrade rust to 1.88

* fix download-release.sh

* add exec/prove time in stats

* Revert "upgrade rust to 1.88"

This reverts commit 283c7c1.

Author: lispc

Makefile

@@ -32,6 +32,9 @@ clean-guest:
 build-guest:
 	sh build-guest.sh
 
+build-guest-local:
+	cargo run --release -p scroll-zkvm-build-guest
+
 clean-build-guest: clean-guest build-guest
 
 clean-test-cache:

crates/prover/src/prover/mod.rs

@@ -242,9 +242,12 @@ impl Prover {
     pub fn gen_proof_stark(&self, stdin: StdIn) -> Result<StarkProof, Error> {
         // Here we always do an execution of the guest program to get the cycle count.
         // and do precheck before proving like ensure PI != 0
+        let t = std::time::Instant::now();
         let total_cycles = self.execute_and_check(&stdin)?;
+        let execution_time_mills = t.elapsed().as_millis() as u64;
 
         let sdk = Sdk::new();
+        let t = std::time::Instant::now();
         let proof = sdk
             .generate_e2e_stark_proof(
                 self.app_pk.clone(),
@@ -253,12 +256,18 @@ impl Prover {
                 stdin,
             )
             .map_err(|e| Error::GenProof(e.to_string()))?;
+        let proving_time_mills = t.elapsed().as_millis() as u64;
+        let stat = StarkProofStat {
+            total_cycles,
+            proving_time_mills,
+            execution_time_mills,
+        };
         let proof = StarkProof {
             proofs: vec![proof.proof],
             public_values: proof.user_public_values,
             //exe_commitment: comm.exe,
             //vm_commitment: comm.vm,
-            stat: StarkProofStat { total_cycles },
+            stat,
         };
         tracing::info!("verifing stark proof");
         UniversalVerifier::verify_stark_proof(&proof, &self.get_app_vk())

crates/types/src/proof.rs

@@ -39,6 +39,10 @@ pub struct EvmProof {
 pub struct StarkProofStat {
     /// total cycles
     pub total_cycles: u64,
+    /// exec time
+    pub execution_time_mills: u64,
+    /// proving time
+    pub proving_time_mills: u64,
 }
 
 /// Helper to modify serde implementations on the remote [`RootProof`] type.

download-release.sh

@@ -1,4 +1,5 @@
 #!/bin/bash
+set -xeu
 
 # release version
 SCROLL_ZKVM_VERSION=0.5.2
@@ -7,19 +8,23 @@ if [ -z "${SCROLL_ZKVM_VERSION}" ]; then
   exit 1
 fi
 
-# chunk-circuit exe
-wget https://circuit-release.s3.us-west-2.amazonaws.com/scroll-zkvm/releases/$SCROLL_ZKVM_VERSION/chunk/app.vmexe -O crates/circuits/chunk-circuit/openvm/app.vmexe
+function download_by_s3() {
+  aws --profile default s3 cp s3://circuit-release/scroll-zkvm/releases/$SCROLL_ZKVM_VERSION releases/$SCROLL_ZKVM_VERSION --recursive
+}
 
-# batch-circuit exe
-wget https://circuit-release.s3.us-west-2.amazonaws.com/scroll-zkvm/releases/$SCROLL_ZKVM_VERSION/batch/app.vmexe -O crates/circuits/batch-circuit/openvm/app.vmexe
+function download_by_http() {
+  for f in chunk/app.vmexe \
+    chunk/openvm.toml \
+    verifier/openVmVk.json \
+    verifier/verifier.bin \
+    bundle/digest_1.hex \
+    bundle/app.vmexe \
+    bundle/digest_2.hex \
+    bundle/openvm.toml \
+    batch/app.vmexe \
+    batch/openvm.toml; do
+    wget https://circuit-release.s3.us-west-2.amazonaws.com/scroll-zkvm/releases/$SCROLL_ZKVM_VERSION/$f -O releases/$SCROLL_ZKVM_VERSION/$f
+  done
+}
 
-# bundle-circuit exe
-wget https://circuit-release.s3.us-west-2.amazonaws.com/scroll-zkvm/releases/$SCROLL_ZKVM_VERSION/bundle/app.vmexe -O crates/circuits/bundle-circuit/openvm/app.vmexe
-
-# bundle-circuit exe, legacy version, may not exist
-wget https://circuit-release.s3.us-west-2.amazonaws.com/scroll-zkvm/releases/$SCROLL_ZKVM_VERSION/bundle/app_euclidv1.vmexe -O crates/circuits/bundle-circuit/openvm/app_euclidv1.vmexe || echo "legacy app not exist for $SCROLL_ZKVM_VERSION"
-
-# assets for verifier-only mode
-wget https://circuit-release.s3.us-west-2.amazonaws.com/scroll-zkvm/releases/$SCROLL_ZKVM_VERSION/verifier/root-verifier-vm-config -O crates/verifier/testdata/root-verifier-vm-config
-wget https://circuit-release.s3.us-west-2.amazonaws.com/scroll-zkvm/releases/$SCROLL_ZKVM_VERSION/verifier/root-verifier-committed-exe -O crates/verifier/testdata/root-verifier-committed-exe
-wget https://circuit-release.s3.us-west-2.amazonaws.com/scroll-zkvm/releases/$SCROLL_ZKVM_VERSION/verifier/verifier.bin -O crates/verifier/testdata/verifier.bin
+download_by_http $SCROLL_ZKVM_VERSION