Unable to disable notification emails when adding drive permissions

[cdwcriver]

The -SendNotificationEmail parameter for the Add-GSDrivePermission permission is a switch parameter. However, this value defaults to true when adding permissions to users and groups, and adding the parameter does not switch this value to false. So, it doesn't seem to be possible to add permissions without sending a notification email.

Steps to reproduce the behavior:

Import-Csv ./testupdateperms.csv | % { Add-GSDrivePermission -User $_.user -FileId $_.fileid -Role $_.Role -Type "group" -EmailAddress $_.NewGroupAddress  }

Expected behavior
Notification email should not be sent for the added permission.

• OS: Ubuntu
• PowerShell Version: Core 6.0.2
• PSGSuite Version: 2.15.1

[n-searle]

Hey,

I had similar behaviours with the -confirm switch which also defaults true, have you tried:
Import-Csv ./testupdateperms.csv | % { Add-GSDrivePermission -User $.user -FileId $.fileid -Role $.Role -Type "group" -EmailAddress $.NewGroupAddress -SendNotificationEmail:$false}

Cheers

[scrthq]

Hey @aitcriver - The default for the standard API is $true: https://developers.google.com/drive/api/v3/reference/permissions/create

It may be worth adding an additional parameter that's more explicit like -DisableNotificationEmail, but I try to at least have the same parameters across the various API's as a minimum unless more are needed.

For now, you can disable email notification as @n-searle mentioned by including -SendNotificationEmail:$false with your call to Add-GSDrivePermission.

[cdwcriver]

Ah, yes, that is helpful, I wasn't exactly sure how to force that parameter to false. Right now, the behavior is that the -SendNotificationEmail parameter does nothing; it is true if the parameter is added of course, but it is also true when it is not added. The only way this parameter does anything is the not-obvious workaround posted here.

A DisableNotificationEmail parameter could work, but I think it would be better to just default to no notification for all cases and then require the -SendNotificationEmail if notifications are desired. Or, change it from a switch parameter to one that accepts a $true/$false value.

I typically use GAM so that's my frame of reference; GAM defaults to no notification emails unless you specify to send one.

[scrthq]

Alright, GitHub is currently going through a data outage, but I have this in a PR ready. Specifically, I updated SendNotificationEmail parameter to default to $false unless specifically called and set to $true with -SendNotificationEmail OR if the permission action is a transfer of ownership (this is a hard requirement by Google for ownership transfers of Drive files). I also updated the doc for the SendNotificationEmail parameter to be more clear

Should hopefully have this out by tomorrow!

[cdwcriver]

Sounds perfect! That was awfully quick, thank you!

[scrthq]

hey @aitcriver - v2.17.1 is out now with that update! let me know how it works for you =]

[cdwcriver]

Thanks! I've verified that it doesn't send the notification email by default now. However, I don't seem to be able to set it to send a notification email. I get an "Add-GSDrivePermission : The property 'SendNotificationEmail' cannot be found on this object. Verify that the property exists and can be set." error:

Compare-ModuleVersion

ModuleName InstalledVersion GalleryVersion UpdateAvailable
---------- ---------------- -------------- ---------------
PSGSuite   2.17.1           2.17.1                   False


Add-GSDrivePermission -User source@example.com -FileId DriveFileId -Role writer -Type user -EmailAddress destination@example.com -SendNotificationEmail
Add-GSDrivePermission : The property 'SendNotificationEmail' cannot be found on this object. Verify that the property exists and can be set.
At line:1 char:1
+ Add-GSDrivePermission -User source@example.com -FileId DriveFile ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
+ FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Add-GSDrivePermission

[scrthq]

Snap!! I think I know what the issue is, I'm on it! Thanks for testing!

On Wed, Oct 24, 2018 at 3:18 PM aitcriver ***@***.***> wrote: Thanks! I've verified that it doesn't send the notification email by default now. However, I don't seem to be able to set it to send a notification email. I get an "Add-GSDrivePermission : The property 'SendNotificationEmail' cannot be found on this object. Verify that the property exists and can be set." error: Compare-ModuleVersion ModuleName InstalledVersion GalleryVersion UpdateAvailable ---------- ---------------- -------------- --------------- PSGSuite 2.17.1 2.17.1 False Add-GSDrivePermission -User ***@***.*** -FileId DriveFileId -Role writer -Type user -EmailAddress ***@***.*** -SendNotificationEmail Add-GSDrivePermission : The property 'SendNotificationEmail' cannot be found on this object. Verify that the property exists and can be set. At line:1 char:1 + Add-GSDrivePermission -User ***@***.*** -FileId DriveFile ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : NotSpecified: (:) [Write-Error], WriteErrorException + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Add-GSDrivePermission — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#103 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMIo3Z799ZQCfyN6cWsFE3UuNqD3Z8Gyks5uoMsegaJpZM4XytKV> .

-- Thank you for your time, Nate Ferrell (SCRT HQ)

[scrthq]

@aitcriver - alright, update to 2.17.2 when you can and let me know if you're solid now!

[cdwcriver]

I've updated, and it looks good now! I don't receive the notification when the -SendNotificationEmail parameter isn't included, and the notification is sent when it is included. Thanks!

[scrthq]

Awesome! Thanks for validating!

_{Sent with GitHawk}