Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update-GSCalendarEvent sets default Start/End times if not passed #59

Closed
scrthq opened this issue Jun 21, 2018 · 1 comment
Closed

Update-GSCalendarEvent sets default Start/End times if not passed #59

scrthq opened this issue Jun 21, 2018 · 1 comment
Assignees
Labels

Comments

@scrthq
Copy link
Member

scrthq commented Jun 21, 2018

Working with @Rtistx on this, should be a quick fix.

Issue is that if you do not specify a Start and/or End time when updating a Calendar event with Update-GSCalendarEvent, it will set the start time as the time the command was run and the end time 30 minutes after that point due to the parameters LocalStartTime and LocalEndTime having the same default values as New-GSCalendarEvent

Code that needs updating is here:

https://github.com/scrthq/PSGSuite/blob/master/PSGSuite/Public/Calendar/Update-GSCalendarEvent.ps1#L104..L107 (needs to have the default values removed)

https://github.com/scrthq/PSGSuite/blob/master/PSGSuite/Public/Calendar/Update-GSCalendarEvent.ps1#L183 (needs to be changed to an elseif statement)

https://github.com/scrthq/PSGSuite/blob/master/PSGSuite/Public/Calendar/Update-GSCalendarEvent.ps1#L198 (needs to be changed to an elseif statement)

@scrthq scrthq added the bug label Jun 21, 2018
@scrthq scrthq self-assigned this Jun 21, 2018
scrthq added a commit that referenced this issue Jun 21, 2018
scrthq added a commit that referenced this issue Jun 21, 2018
#### 2.7.1

* Fixed: `Update-GSCalendarEvent` had default values set for LocalStartDateTime and LocalEndDateTime parameters, causing those to always update the event unexpectedly if a start and/or end datetime was not passed when running the command ([Issue #59](#59))
@scrthq
Copy link
Member Author

scrthq commented Jun 21, 2018

resolved in v2.7.1

@scrthq scrthq closed this as completed Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant