Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/Example for WebAssembly #767

Open
Niederb opened this issue Apr 25, 2024 · 3 comments · Fixed by #772
Open

Test/Example for WebAssembly #767

Niederb opened this issue Apr 25, 2024 · 3 comments · Fixed by #772
Assignees

Comments

@Niederb
Copy link
Contributor

Niederb commented Apr 25, 2024

It would be nice to have an example that works with WebAssembly. We should also have some tests that run a WebAssembly executable.
Some of the existing examples might actually work but it would still be nice to document this.

  • Find/Write an example that works with wasm
    • Run this example with a wasm runtime
  • Documentation
    • What does work with WebAssembly
    • Differences between wasm-unknown-unknown and wasm-wasip1
    • Differences no_std and wasm
@Niederb Niederb self-assigned this Jun 5, 2024
@Niederb
Copy link
Contributor Author

Niederb commented Jun 10, 2024

Using the kitchensink_runtime seems very problematic. As soon as it is included the wasm module cannot be instantiated anymore 👎

Error: failed to run main module `target/wasm32-unknown-unknown/release/examples/wasm_example.wasm`

Caused by:
    0: failed to instantiate "target/wasm32-unknown-unknown/release/examples/wasm_example.wasm"
    1: unknown import: `env::ext_trie_blake2_256_ordered_root_version_2` has not been defined

@masapr
Copy link
Collaborator

masapr commented Jun 11, 2024

@Niederb What's your suggestion on how we should continue with this? Should we try to fix this in the kitchensink_runtime (with the goal to do a PR there?) or create an example with a different runtime? Or just pause this issue and try again in the future?

@Niederb Niederb linked a pull request Jun 11, 2024 that will close this issue
@Niederb
Copy link
Contributor Author

Niederb commented Jun 11, 2024

I already worked quite a bit on the test infrastructure. At least a very minimal example should be possible and I think having something running with WebAssembly would already be useful.

@masapr masapr reopened this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants