"telegramEnabled" remains always true, even when trying to disable Telegram notifications (api)

[LetsGoDude]

Description

Hi Overseerr Team,

I've noticed that regardless of how I send the telegramEnabled field in the POST /api/v1/user/<ID>/settings/notifications endpoint, Overseerr always retains telegramEnabled: true.
Setting it to false in the request body does not actually disable Telegram notifications. Instead notificationTypes.telegram is set to 0 (e.g., "telegram": 0)—at which point telegramEnabled still remains true, even though notifications are effectively disabled.

Not a big problem, but it just doesn't behave as you would expect.
I bypassed it by setting ‘notificationTypes’: {
‘telegram": 3661 } to activate and 0 to deactivate.

Version

1.33.2

Steps to Reproduce

Make a POST request to /api/v1/user/<OVERSEERR_USER_ID>/settings/notifications with:

# Nothing applies here. Notification Types all remain deactivated.

{
  "notificationTypes": {
    "telegramEnabled": true
  },
  "telegramSendSilently": true
}

{
  "notificationTypes": {
    "telegramEnabled": false
  },
  "telegramSendSilently": true
}

# Notification types are all deactivated, but ‘telegramEnabled’ remains true.

Screenshots

Logs

Platform

desktop

Device

x86 PC AMD

Operating System

ubuntu 24.04 desktop

Browser

Firefox / Chrome

Additional Context

No response

Code of Conduct

• I agree to follow Overseerr's Code of Conduct

[didyouexpectthat]

When you do a GET request against /api/v1/user/<ID>/settings/notifications, it outputs the system's setting for Telegram, not a user-level Telegram toggle.

overseerr/server/routes/user/usersettings.ts

Lines 264 to 284 in 3242251

	return res.status(200).json({
	emailEnabled: settings.email.enabled,
	pgpKey: user.settings?.pgpKey,
	discordEnabled:
	settings?.discord.enabled && settings.discord.options.enableMentions,
	discordEnabledTypes:
	settings?.discord.enabled && settings.discord.options.enableMentions
	? settings.discord.types
	: 0,
	discordId: user.settings?.discordId,
	pushbulletAccessToken: user.settings?.pushbulletAccessToken,
	pushoverApplicationToken: user.settings?.pushoverApplicationToken,
	pushoverUserKey: user.settings?.pushoverUserKey,
	pushoverSound: user.settings?.pushoverSound,
	telegramEnabled: settings.telegram.enabled,
	telegramBotUsername: settings.telegram.options.botUsername,
	telegramChatId: user.settings?.telegramChatId,
	telegramSendSilently: user.settings?.telegramSendSilently,
	webPushEnabled: settings.webpush.enabled,
	notificationTypes: user.settings?.notificationTypes ?? {},
	});

When you go to POST, it is only looking at actual user preferences, like what you see in the front-end.

overseerr/server/routes/user/usersettings.ts

Lines 314 to 341 in 3242251

	if (!user.settings) {
	user.settings = new UserSettings({
	user: req.user,
	pgpKey: req.body.pgpKey,
	discordId: req.body.discordId,
	pushbulletAccessToken: req.body.pushbulletAccessToken,
	pushoverApplicationToken: req.body.pushoverApplicationToken,
	pushoverUserKey: req.body.pushoverUserKey,
	telegramChatId: req.body.telegramChatId,
	telegramSendSilently: req.body.telegramSendSilently,
	notificationTypes: req.body.notificationTypes,
	});
	} else {
	user.settings.pgpKey = req.body.pgpKey;
	user.settings.discordId = req.body.discordId;
	user.settings.pushbulletAccessToken = req.body.pushbulletAccessToken;
	user.settings.pushoverApplicationToken =
	req.body.pushoverApplicationToken;
	user.settings.pushoverUserKey = req.body.pushoverUserKey;
	user.settings.pushoverSound = req.body.pushoverSound;
	user.settings.telegramChatId = req.body.telegramChatId;
	user.settings.telegramSendSilently = req.body.telegramSendSilently;
	user.settings.notificationTypes = Object.assign(
	{},
	user.settings.notificationTypes,
	req.body.notificationTypes
	);
	}

There is no toggle to enable/disable Telegram per user, except perhaps editing the Chat ID or set which notificationTypes for Telegram are sent to the user.