Fix for issue#359. Guard stcb->sctp_ep when setting the 'connecting' … #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flag to prevent race conditions when two threads are binding and connecting to a socket.
tuexen
reviewed
Aug 30, 2019
| @@ -8179,11 +8179,13 @@ sctpconn_connect(struct socket *so, struct sockaddr *addr) | |||
| /* Gak! no memory */ | |||
| goto out_now; | |||
| } | |||
| if (stcb->sctp_ep->sctp_flags & SCTP_PCB_FLAGS_TCPTYPE) { | |||
| SCTP_INP_RLOCK(stcb->sctp_ep); | |||
There was a problem hiding this comment.
You can't aquire an inp lock here since you own already the stcb lock. This would result in a LOR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard stcb->sctp_ep when setting the 'connecting' flag to prevent race conditions when two threads are binding and connecting to a socket.