feat(retry render and dnb): retry puppetteer on failure and render routes on full render only (#256)

Author: SanderElias

scully/renderPlugins/puppeteerRenderPlugin.ts

@@ -8,6 +8,8 @@ import {scullyConfig} from '../utils/config';
 import {logError, yellow} from '../utils/log';
 import {launchedBrowser} from './launchedBrowser';
 
+const errorredPages = new Set<string>();
+
 export const puppeteerRender = async (route: HandledRoute): Promise<string> => {
   let version = '0.0.0';
   try {
@@ -70,6 +72,16 @@ export const puppeteerRender = async (route: HandledRoute): Promise<string> => {
     // tslint:disable-next-line: no-unused-expression
     page && typeof page.close === 'function' && (await page.close());
     logError(`Puppeteer error while rendering "${yellow(route.route)}"`, err);
+    if (errorredPages.has(route.route)) {
+      /** we tried this page before, something is really off. Exit stage left. */
+      process.exit(15);
+    } else {
+      errorredPages.add(route.route);
+      /** give it a couple of secs */
+      await waitForIt(3 * 1000);
+      /** retry! */
+      return puppeteerRender(route);
+    }
   }
 
   return pageHtml;

scully/utils/defaultAction.ts

@@ -20,7 +20,7 @@ const {baseFilter} = yargs
   .describe('bf', 'provide a minimatch glob for the unhandled routes').argv;
 
 console.log(baseFilter);
-export const generateAll = async (config?: Partial<ScullyConfig>) => {
+export const generateAll = async (config?: Partial<ScullyConfig>, localBaseFilter = baseFilter) => {
   if (config) {
     await updateScullyConfig(config);
   }
@@ -36,10 +36,13 @@ export const generateAll = async (config?: Partial<ScullyConfig>) => {
 
     log('Pull in data to create additional routes.');
     const handledRoutes = await addOptionalRoutes(
-      unhandledRoutes.filter((r: string) => r && r.startsWith(baseFilter))
+      unhandledRoutes.filter((r: string) => r && r.startsWith(localBaseFilter))
     );
     /** save routerinfo, so its available during rendering */
-    await storeRoutes(handledRoutes);
+    if (localBaseFilter === '') {
+      /** only store when the routes are complete  */
+      await storeRoutes(handledRoutes);
+    }
 
     /** launch the browser, its shared among renderers */
     const browser = await launchedBrowser();