schematics: inputs should be sanitized

[timdeschryver]

🐞 Bug report

Description

The inputs for the schematics to create a post or markdown should be sanitized.

🔬 Minimal Reproduction

The following command generated a new post as /blog/first/post.md, the post will not be found in this case.

ng g @scullyio/init:post --name="first/post"

A similar thing happens to the markdown schematic, this command creates invalid JSON in the config:

ng g @scullyio/init:markdown --name=my-test! --slug=my-test!

exports.config = {
  projectRoot: "./src/app",
  routes: {
    '/my-test!/:my-test!': {
      type: 'contentFolder',
      my-test!: {
        folder: "./my-test!"
      }
    }
  }
};

💻Your Environment

Angular Version:

Latest

Scully Version:

Latest

🔥 Exception or Error

[d-koppenhagen]

#177 should face this issue. I created some more tests check the options will be dasherized / camelized / normalized

[d-koppenhagen]

But I checked it again: special chars like "!" will still be kept. They should be filtered.

[d-koppenhagen]

I think replacing all special chars except _ should be used additionally for dasherized and camelized parts:

const final = original.replace(/[^a-zA-Z-]/g, '');

And replacing all special chars except / and - should be used additionally for the route parts parts:

const final = original.replace(/[^a-zA-Z\/-]/g, '');

[d-koppenhagen]

I think there are two possibly ways to handle this:
a) filter all non numeric or ASCII characters and remove them except in a generated markdown file
b) throw an exception (The the way how it's handled by e.g. ng g c foo!)

@jorgeucano what do you think?

[jorgeucano]

fixed in the new version :)

[d-koppenhagen]

@jorgeucano shouldn't toAscii also be applied to the route option?

[d-koppenhagen]

sent a PR: #210