Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/schematic options #149

Merged
merged 17 commits into from
Jan 9, 2020
Merged

Feat/schematic options #149

merged 17 commits into from
Jan 9, 2020

Conversation

d-koppenhagen
Copy link
Contributor

@d-koppenhagen d-koppenhagen commented Jan 6, 2020 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #100

What is the new behavior?

This PR will implement the options for schematics as discussed in #100

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jorgeucano
Copy link
Contributor

Hey, I’m return in 2 days to work ... and i will review all.. thanks for all of this work 💪

@d-koppenhagen
Copy link
Contributor Author

Awesome. I will also work on providing some schematic tests

@aaronfrost
Copy link
Contributor

See my comments and then I can approve. @d-koppenhagen

@d-koppenhagen
Copy link
Contributor Author

@aaronfrost jep I will solve this later. Nonetheless a bit of docs and probably tests are missing. I will add them.

Also there is still an ongoing discussion in #100 about more options for posts for configuring meta data. I think your opinion to the suggestions I made would be great to have.

@d-koppenhagen
Copy link
Contributor Author

@jorgeucano i've also done a bit of refactoring and I added some more test specs. It would be good to check all this in detail and tests it again :)

@d-koppenhagen d-koppenhagen changed the title WIP: Feat/schematic options Feat/schematic options Jan 7, 2020
@jorgeucano
Copy link
Contributor

hey @ d-koppenhagen this is a great job! Thanks, can you describe all the changes in a list? ... I need this to test the functionalities

@d-koppenhagen
Copy link
Contributor Author

Sure. I will do this later.
But most things should be tested now by running npm test inside schematics/scully (I don’t know if the tests are also executed within a bigger test for scully in general using bazel?)
My plan was to add some more schematic tests today

@jorgeucano
Copy link
Contributor

jorgeucano commented Jan 8, 2020 •
edited
Loading

I really love the idea, one of my next tasks is to start writing the test ... but, in this case, please add me the list and when we merge this ... we can create other pr ... I like a pr by functionality/issue/etc ... it is easier to test and work :)

@d-koppenhagen
Copy link
Contributor Author

Yes you are probably right. Let's merge this and face tests and more functionality in separate MR's and issues.

So here is the list:

  • feature: provide more options for @sculllyio/init:markdown (Options for @scullyio/init:markdown and @scullyio/init:blog #100)
    • sourceDir: define a source dir name (when not used, name is used instead)
    • route: define a route path before the :slug (when not used, name is used instead)
  • feature: provide more options for @sculllyio/init:post (Options for @scullyio/init:markdown and @scullyio/init:blog #100)
    • target: define the target directory for the new post file (by default blog is used)
    • metaDataFile: use a meta data yaml template from a file for usage within the post (title will be overridden by the name option if set)
  • feature: use yyyy-mm-dd as date format in the file name for the initially created markdown file when using @sculllyio/init:markdown (31e1ebd)
    • just as it is more common
  • tests: added test-utils.ts for easier test setup (01f4531)
  • docs: updated docs file with schematics options for @sculllyio/init:markdown and @sculllyio/init:post (Options for @scullyio/init:markdown and @scullyio/init:blog #100)
  • refactoring: split ng-add schematic into smaller chainable rules (50e7bec)
  • tests: add tests for several schematics (ng-add, scully, create-markdown, add-post)
  • refactor: add schema for add-blog schematic (68c5c0c)

@d-koppenhagen
Merge remote-tracking branch 'upstream/master' into feat/schematic-op…
4fd2cb0 
…tions

* upstream/master:
  feat(voidplugin): plugin that lets you exclude routes
  fix(scully readme): put readme back on npm
  feat(schematics): add support for nx monorepos (scullyio#162)
  Postrenderers addition (scullyio#160)
  chore(script): 🤖 add commit select for commit only the file the pr need (scullyio#158)
  improvement(scully): export built-in plugins (scullyio#153)
  feat(transferstateservice): Fix ngc error (scullyio#152)
@jorgeucano
Copy link
Contributor

@d-koppenhagen i created a little change for support nx with schematics, can you pull from master and merge :) after this i will Approve :) thanks for all of this work

@d-koppenhagen
Copy link
Contributor Author

@jorgeucano already done 😃 see 4fd2cb0

@jorgeucano jorgeucano merged commit 9a9d4ea into scullyio:master Jan 9, 2020
@jorgeucano
Copy link
Contributor

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfrost aaronfrost aaronfrost left review comments

@jorgeucano jorgeucano jorgeucano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Options for @scullyio/init:markdown and @scullyio/init:blog
3 participants
@d-koppenhagen @jorgeucano @aaronfrost