Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Scully config): adds an option to set the puppeteer launch options #184

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

SanderElias
Copy link
Contributor

closes #181
add an option to the config to set puppeteers launch options. might be needed in restricted environments

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

None
Issue Number: #181

What is the new behavior?

have an option to address #181

Does this PR introduce a breaking change?

  • Yes
  • No

@jorgeucano jorgeucano merged commit f81c560 into master Jan 15, 2020
@jorgeucano jorgeucano deleted the sander/puppeteerLaunchSettings branch January 15, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--disable-extensions for Windows
2 participants