feat(frontmatter handling): handle published and slug parameters #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeucano
approved these changes
Jan 21, 2020
Villanuevand
approved these changes
Jan 21, 2020
d-koppenhagen
pushed a commit
to d-koppenhagen/scully
that referenced
this pull request
Jan 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
none, as this is a new feature
What is the new behavior?
a couple of things:
publishedin content files. When this is set to false, there will be a temporary slug where the file is rendered, and it's taken out of the available$ observable in sullyRouteServiceslugthis will be used for the routeDoes this PR introduce a breaking change?