Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(staticserver): add option for use ssl into the static server #293

Merged
merged 3 commits into from
Feb 12, 2020
Merged

feat(staticserver): add option for use ssl into the static server #293

merged 3 commits into from
Feb 12, 2020

Conversation

jorgeucano
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Add a new option for use ssl into the static scully server

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Villanuevand
Villanuevand approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@Villanuevand Villanuevand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jorgeucano
Copy link
Contributor Author

I add options for support to read files with ssl-cert ssl-key!
So now, you can use the selfcreated or your ssl.
@SanderElias @aaronfrost

SanderElias
SanderElias approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeucano jorgeucano merged commit dbdfc89 into master Feb 12, 2020
@jorgeucano jorgeucano deleted the feat/ssl branch February 12, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanderElias SanderElias SanderElias approved these changes

@Villanuevand Villanuevand Villanuevand approved these changes

@aaronfrost aaronfrost Awaiting requested review from aaronfrost

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeucano @Villanuevand @SanderElias