Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit error #189

Closed
mengerj opened this issue Nov 13, 2024 · 4 comments · Fixed by #190
Closed

Pre-commit error #189

mengerj opened this issue Nov 13, 2024 · 4 comments · Fixed by #190

Comments

@mengerj
Copy link
Contributor

mengerj commented Nov 13, 2024

Hi,
I am attemping to add tutorials of ecosystem packages to the scverse-tutorial repo. When trying to merge my pull request, the pre-commit bot gives this error:
Expected one of commit-msg, manual, post-checkout, post-commit, post-merge, post-rewrite, pre-commit, pre-merge-commit, pre-push, pre-rebase, prepare-commit-msg but got: 'Nonepre-commitNone'

regarding the .pre-commit-config.yaml file. Not sure if this a pre-commit version issue or different default_stages should be chosen or if it is something else...
#188

Thanks!

Best,
Jonatan

@grst
Copy link
Collaborator

grst commented Nov 13, 2024

Hi @mengerj,

yes, there has recently been an update to the pre-commit config files.
Can you try to run pre-commit migrate-config?

@mengerj
Copy link
Contributor Author

mengerj commented Nov 13, 2024

running pre-commit migrate-config didn't result in any changes. It works if you manually remove the "None" parts of the names. Do you know why they were there in the first place? Included the change in my pull-request. I wanted to have a seperate pull request for that change by checking out into a new branch first, but It seems it is still included in my previous pull-request. Hope it's fine.

@grst
Copy link
Collaborator

grst commented Nov 13, 2024

Many thanks, I have no idea how the None ended up there.

@flying-sheep flying-sheep linked a pull request Nov 15, 2024 that will close this issue
@flying-sheep
Copy link
Member

pre-commit autoupdate had an oopsie, not our fault

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants