Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model request: non-negative spatial factorization (NSF) #1859

Open
aribenjamin opened this issue Jan 18, 2023 · 4 comments
Open

Model request: non-negative spatial factorization (NSF) #1859

aribenjamin opened this issue Jan 18, 2023 · 4 comments
Assignees
Labels
backlog enhancement new model Proposals to implement new model

Comments

@aribenjamin
Copy link

Is anyone currently working on implementing NSF? It's a nice probabilistic method designed with spatial transcriptomics in mind. https://www.nature.com/articles/s41592-022-01687-w

It'd be nice to work with this here, within scvi-tools. The authors' implementation (@ https://github.com/willtownes/nsf-paper) is a little hard to parse and implemented with Tensorflow as a backend (which I don't work in).

@adamgayoso
Copy link
Member

I think this would be a nice addition. It might be easiest to implement using tensorflow probability and jax as the kernel functions should be the same; unless of course it's also straightforward in pytorch. Are you willing to contribute this?

@adamgayoso adamgayoso added the new model Proposals to implement new model label Jan 18, 2023
@aribenjamin
Copy link
Author

Yes, I'm happy to go for it. It'd be good practice contributing. I can't guarantee any timeline, though, so if someone wants this sooner please ping me.

@adamgayoso
Copy link
Member

Looking into this more, it should be possible with just PyTorch, or just jax+numpyro (which we already depend on), without the introduction of tensorflow probability. @martinkim0 do you want to try this model? It looks both fairly straightforward and fun.

@aribenjamin
Copy link
Author

fyi I have back-burnered this to the point of inaction. If you want to work on this, know that I'm not working in parallel. I'll update this when and if I begin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement new model Proposals to implement new model
Projects
None yet
Development

No branches or pull requests

3 participants