New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visium HD alignment sometimes require a projective transformation, affine not enough #242

Open

LucaMarconato opened this issue Nov 22, 2024 · 1 comment · May be fixed by #247

Member

LucaMarconato commented Nov 22, 2024 •

edited

Loading

It has been pointed out that in this part of Visium HD reader

spatialdata-io/src/spatialdata_io/readers/visium_hd.py

Line 402 in 3c6be23

matrix[2] = [0, 0, 1]

we need to maintain the matrix as read and interpret it as a projective transformation.

Projective transformations are currently not supported by NGFF, I will investigate the problem.

LucaMarconato linked a pull request

that will close this issue

Visium HD fix bug projective transformation (CytAssist image) #247

Open

Member Author

LucaMarconato commented Dec 8, 2024

See comments in the linked PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment