Skip to content

Commit 1749a4a

Browse files
authored
Merge pull request #161 from muzarski/remove_from_unimplemented
testing: remove implemented functions from `testing_unimplemented.cpp`
2 parents 7fc403b + 9f43fb0 commit 1749a4a

File tree

3 files changed

+10
-13
lines changed

3 files changed

+10
-13
lines changed

.github/workflows/build.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,13 @@ jobs:
5050
:ByNameTests.*\
5151
:CompressionTests.*\
5252
:LoggingTests.*\
53+
:PreparedMetadataTests.*\
54+
:UseKeyspaceCaseSensitiveTests.*\
5355
:-PreparedTests.Integration_Cassandra_PreparedIDUnchangedDuringReprepare\
5456
:ExecutionProfileTest.InvalidName\
55-
:*NoCompactEnabledConnection"
57+
:*NoCompactEnabledConnection\
58+
:PreparedMetadataTests.Integration_Cassandra_AlterDoesntUpdateColumnCount\
59+
:UseKeyspaceCaseSensitiveTests.Integration_Cassandra_ConnectWithKeyspace"
5660
run: valgrind --error-exitcode=123 --leak-check=full --errors-for-leak-kinds=definite ./cassandra-integration-tests --scylla --version=release:6.0.0 --category=CASSANDRA --verbose=ccm --gtest_filter="$Tests"
5761

5862
- name: Upload test logs

.github/workflows/cassandra.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,15 @@ jobs:
5151
:ByNameTests.*\
5252
:CompressionTests.*\
5353
:LoggingTests.*\
54+
:PreparedMetadataTests.*\
55+
:UseKeyspaceCaseSensitiveTests.*\
5456
:-PreparedTests.Integration_Cassandra_PreparedIDUnchangedDuringReprepare\
5557
:PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare\
5658
:SslTests.Integration_Cassandra_ReconnectAfterClusterCrashAndRestart\
5759
:ExecutionProfileTest.InvalidName\
58-
:*NoCompactEnabledConnection"
60+
:*NoCompactEnabledConnection\
61+
:PreparedMetadataTests.Integration_Cassandra_AlterDoesntUpdateColumnCount\
62+
:UseKeyspaceCaseSensitiveTests.Integration_Cassandra_ConnectWithKeyspace"
5963
run: valgrind --error-exitcode=123 --leak-check=full --errors-for-leak-kinds=definite ./cassandra-integration-tests --version=4.0.7 --category=CASSANDRA --verbose=ccm --gtest_filter="$Tests"
6064

6165
- name: Upload test logs

src/testing_unimplemented.cpp

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -131,11 +131,6 @@ cass_cluster_set_prepare_on_up_or_add_host(CassCluster* cluster,
131131
throw std::runtime_error("UNIMPLEMENTED cass_cluster_set_prepare_on_up_or_add_host\n");
132132
}
133133
CASS_EXPORT void
134-
cass_cluster_set_retry_policy(CassCluster* cluster,
135-
CassRetryPolicy* retry_policy){
136-
throw std::runtime_error("UNIMPLEMENTED cass_cluster_set_retry_policy\n");
137-
}
138-
CASS_EXPORT void
139134
cass_cluster_set_timestamp_gen(CassCluster* cluster,
140135
CassTimestampGen* timestamp_gen){
141136
throw std::runtime_error("UNIMPLEMENTED cass_cluster_set_timestamp_gen\n");
@@ -300,12 +295,6 @@ CASS_EXPORT CassVersion
300295
cass_schema_meta_version(const CassSchemaMeta* schema_meta){
301296
throw std::runtime_error("UNIMPLEMENTED cass_schema_meta_version\n");
302297
}
303-
CASS_EXPORT CassFuture*
304-
cass_session_connect_keyspace(CassSession* session,
305-
const CassCluster* cluster,
306-
const char* keyspace){
307-
throw std::runtime_error("UNIMPLEMENTED cass_session_connect_keyspace\n");
308-
}
309298
CASS_EXPORT void
310299
cass_session_get_metrics(const CassSession* session,
311300
CassMetrics* output){

0 commit comments

Comments
 (0)