Skip to content

Commit c458fef

Browse files
committed
makefile: fix rebuild IT binary condition
Currently, we rebuild (even if it exists) IT binary if DONT_REBUILD_INTEGRATION_BIN env var is non-empty. I believe it should be the opposite.
1 parent e4396cd commit c458fef

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -172,18 +172,18 @@ download-ccm-cassandra-image: install-ccm-if-missing
172172

173173
run-test-integration-scylla: prepare-integration-test download-ccm-scylla-image
174174
ifeq ($(DONT_REBUILD_INTEGRATION_BIN), $(EMPTY))
175-
run-test-integration-scylla: build-integration-test-bin-if-missing
176-
else
177175
run-test-integration-scylla: build-integration-test-bin
176+
else
177+
run-test-integration-scylla: build-integration-test-bin-if-missing
178178
endif
179179
@echo "Running integration tests on scylla ${SCYLLA_VERSION}"
180180
valgrind --error-exitcode=123 --leak-check=full --errors-for-leak-kinds=definite build/cassandra-integration-tests --scylla --version=${SCYLLA_VERSION} --category=CASSANDRA --verbose=ccm --gtest_filter="${SCYLLA_TEST_FILTER}"
181181

182182
run-test-integration-cassandra: prepare-integration-test download-ccm-cassandra-image install-java8-if-missing
183183
ifeq ($(DONT_REBUILD_INTEGRATION_BIN), $(EMPTY))
184-
run-test-integration-cassandra: build-integration-test-bin-if-missing
185-
else
186184
run-test-integration-cassandra: build-integration-test-bin
185+
else
186+
run-test-integration-cassandra: build-integration-test-bin-if-missing
187187
endif
188188
@echo "Running integration tests on cassandra ${CASSANDRA_VERSION}"
189189
valgrind --error-exitcode=123 --leak-check=full --errors-for-leak-kinds=definite build/cassandra-integration-tests --version=${CASSANDRA_VERSION} --category=CASSANDRA --verbose=ccm --gtest_filter="${CASSANDRA_TEST_FILTER}"

0 commit comments

Comments
 (0)