Skip to content

Commit e544130

Browse files
committed
it: enable 4 out of 5 TimestampTests
The remaining test (MonotonicTimestampGenerator) needs further adjustments. Currently it segfaults - I'll create a separate issue for this one. TLDR - currently, the generator provided to `cass_cluster_set_timestamp_gen` is constructed using pure c++ API (no API from cassandra.h is used). It depends on `src/timestamp_generator.cpp`, which we should ultimately remove. However, to remove this file, we need to implement a testing utility which allows us to read the generated timestamps during the test. The test would then need to be rewritten using this new utility.
1 parent 420dc09 commit e544130

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

Makefile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ SCYLLA_TEST_FILTER := $(subst ${SPACE},${EMPTY},ClusterTests.*\
2525
:LoggingTests.*\
2626
:PreparedMetadataTests.*\
2727
:UseKeyspaceCaseSensitiveTests.*\
28+
:TimestampTests.*\
2829
:MetricsTests.Integration_Cassandra_ErrorsRequestTimeouts\
2930
:MetricsTests.Integration_Cassandra_Requests\
3031
:MetricsTests.Integration_Cassandra_StatsShardConnections\
@@ -37,6 +38,7 @@ SCYLLA_TEST_FILTER := $(subst ${SPACE},${EMPTY},ClusterTests.*\
3738
:ExecutionProfileTest.Integration_Cassandra_LatencyAwareRouting\
3839
:-PreparedTests.Integration_Cassandra_PreparedIDUnchangedDuringReprepare\
3940
:HeartbeatTests.Integration_Cassandra_HeartbeatFailed\
41+
:TimestampTests.Integration_Cassandra_MonotonicTimestampGenerator\
4042
:ControlConnectionTests.Integration_Cassandra_TopologyChange\
4143
:ControlConnectionTests.Integration_Cassandra_FullOutage\
4244
:ControlConnectionTests.Integration_Cassandra_TerminatedUsingMultipleIoThreadsWithError\
@@ -73,6 +75,7 @@ CASSANDRA_TEST_FILTER := $(subst ${SPACE},${EMPTY},ClusterTests.*\
7375
:LoggingTests.*\
7476
:PreparedMetadataTests.*\
7577
:UseKeyspaceCaseSensitiveTests.*\
78+
:TimestampTests.*\
7679
:MetricsTests.Integration_Cassandra_ErrorsRequestTimeouts\
7780
:MetricsTests.Integration_Cassandra_Requests\
7881
:MetricsTests.Integration_Cassandra_StatsShardConnections\
@@ -86,6 +89,7 @@ CASSANDRA_TEST_FILTER := $(subst ${SPACE},${EMPTY},ClusterTests.*\
8689
:-PreparedTests.Integration_Cassandra_PreparedIDUnchangedDuringReprepare\
8790
:PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare\
8891
:HeartbeatTests.Integration_Cassandra_HeartbeatFailed\
92+
:TimestampTests.Integration_Cassandra_MonotonicTimestampGenerator\
8993
:ControlConnectionTests.Integration_Cassandra_TopologyChange\
9094
:ControlConnectionTests.Integration_Cassandra_FullOutage\
9195
:ControlConnectionTests.Integration_Cassandra_TerminatedUsingMultipleIoThreadsWithError\

0 commit comments

Comments
 (0)