Skip to content

testing: remove implemented functions from testing_unimplemented.cpp #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2024
Merged

testing: remove implemented functions from testing_unimplemented.cpp #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d976f8
testing: remove cass_cluster_set_RP from testing_unimplemented
muzarski Sep 6, 2024
9f43fb0
testing: remove cass_session_connect_keyspace from testing_unimplemented
muzarski Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,13 @@ jobs:
:ByNameTests.*\
:CompressionTests.*\
:LoggingTests.*\
:PreparedMetadataTests.*\
:UseKeyspaceCaseSensitiveTests.*\
:-PreparedTests.Integration_Cassandra_PreparedIDUnchangedDuringReprepare\
:ExecutionProfileTest.InvalidName\
:*NoCompactEnabledConnection"
:*NoCompactEnabledConnection\
:PreparedMetadataTests.Integration_Cassandra_AlterDoesntUpdateColumnCount\
:UseKeyspaceCaseSensitiveTests.Integration_Cassandra_ConnectWithKeyspace"
run: valgrind --error-exitcode=123 --leak-check=full --errors-for-leak-kinds=definite ./cassandra-integration-tests --scylla --version=release:6.0.0 --category=CASSANDRA --verbose=ccm --gtest_filter="$Tests"

- name: Upload test logs
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/cassandra.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,15 @@ jobs:
:ByNameTests.*\
:CompressionTests.*\
:LoggingTests.*\
:PreparedMetadataTests.*\
:UseKeyspaceCaseSensitiveTests.*\
:-PreparedTests.Integration_Cassandra_PreparedIDUnchangedDuringReprepare\
:PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare\
:SslTests.Integration_Cassandra_ReconnectAfterClusterCrashAndRestart\
:ExecutionProfileTest.InvalidName\
:*NoCompactEnabledConnection"
:*NoCompactEnabledConnection\
:PreparedMetadataTests.Integration_Cassandra_AlterDoesntUpdateColumnCount\
:UseKeyspaceCaseSensitiveTests.Integration_Cassandra_ConnectWithKeyspace"
run: valgrind --error-exitcode=123 --leak-check=full --errors-for-leak-kinds=definite ./cassandra-integration-tests --version=4.0.7 --category=CASSANDRA --verbose=ccm --gtest_filter="$Tests"

- name: Upload test logs
Expand Down
11 changes: 0 additions & 11 deletions src/testing_unimplemented.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,6 @@ cass_cluster_set_prepare_on_up_or_add_host(CassCluster* cluster,
throw std::runtime_error("UNIMPLEMENTED cass_cluster_set_prepare_on_up_or_add_host\n");
}
CASS_EXPORT void
cass_cluster_set_retry_policy(CassCluster* cluster,
CassRetryPolicy* retry_policy){
throw std::runtime_error("UNIMPLEMENTED cass_cluster_set_retry_policy\n");
}
CASS_EXPORT void
cass_cluster_set_timestamp_gen(CassCluster* cluster,
CassTimestampGen* timestamp_gen){
throw std::runtime_error("UNIMPLEMENTED cass_cluster_set_timestamp_gen\n");
Expand Down Expand Up @@ -300,12 +295,6 @@ CASS_EXPORT CassVersion
cass_schema_meta_version(const CassSchemaMeta* schema_meta){
throw std::runtime_error("UNIMPLEMENTED cass_schema_meta_version\n");
}
CASS_EXPORT CassFuture*
cass_session_connect_keyspace(CassSession* session,
const CassCluster* cluster,
const char* keyspace){
throw std::runtime_error("UNIMPLEMENTED cass_session_connect_keyspace\n");
}
CASS_EXPORT void
cass_session_get_metrics(const CassSession* session,
CassMetrics* output){
Expand Down