Skip to content

CI: some tests are unnecessarily skipped when run against Scylla #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #132
muzarski opened this issue Jul 24, 2024 · 0 comments · Fixed by #155
Closed
Tracked by #132

CI: some tests are unnecessarily skipped when run against Scylla #144

muzarski opened this issue Jul 24, 2024 · 0 comments · Fixed by #155
Assignees

Comments

@muzarski
Copy link
Collaborator

A simple example are tests for duration cql type:

[SKIPPED] Unsupported for Apache Cassandra Version 3.0.8: Server version 3.10+ is required
[OK]      CassandraTypesDurationTests.Integration_Cassandra_MixedValues (1937 ms)

When scylla cluster is set up via ccm (no matter the version of scylla), the ccm <node> version command always returns a 3.0.8 version. This version is probably hardcoded in nodetool (ccm <node> version command delegates it to nodetool). However, there is a way to print a scylla version using ccm. There is a ccm <node> versionfrombuild command which seems to display the correct version of scylla node.

We need to adjust the logic responsible for filtering out the tests based on Scylla/Cassandra version. Testing framework should be aware whether it's used against Cassandra or Scylla cluster, and then execute either ccm <node> version or ccm <node> versionfrombuild respectively. Minimal versions required for specific tests should be adjusted for scylla, because I believe that there is no 1:1 mapping between Scylla's and Cassandra's versions and some features were probably introduced in different versions.

@muzarski muzarski self-assigned this Jul 24, 2024
@muzarski muzarski changed the title CI: some tests are unnecessary skipped when run against Scylla CI: some tests are unnecessarily skipped when run against Scylla Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant