Adjust and enable 5 out of 11 ExecutionProfile integration tests #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. This test entry was placed after "-" sign. The tests after this are excluded (explicitly disabled). 2. The syntax for test filter was just wrong. "ExecutionProfileTest.InvalidName" did not pick up anything.
Analogous method is already present for CassStatement.
This test sets a low (1ms) request timeout using "request_timeout" execution profile. It expects a request timeout error. It is adjusted, so we simulate the 2>=ms latency for the requests. Otherwise, this test is too flaky - especially in the local setup.
I modified the test by a lot. The idea behind this is explained in the comment. TLDR - we expect setting bad serial consistency to fail on client side, not on the server side. I left original test case commented for reference.
We just needed to adjust the log filter criteria to match the logs emitted by rust-driver.
muzarski
added
area/testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #132
Enabled tests:
InvalidNameRequestTimeoutConsistencySerialConsistencyLatencyAwareRoutingTests that we could not enable (yet):
RetryPolicy<- this one requires to implementcass_retry_policy_logging_newRoundRobin<- requirescass_future_coordinatorTokenAwareRouting<- currently requirescass_statement_set_key_indexandcass_statement_set_keyspace. These are not going to be supported by rust-driver (most probably). I'll need to investigate if the test could be rewritten using prepared statements. If so, this will be a part of separate PR.BlacklistFiltering<- requirescass_[cluster/execution_profile]_set_blacklist_filteringWhitelistFiltering<-cass_[cluster/execution_profile]_set_whitelist_filteringSpeculativeExecutionPolicy<- it throws some error related to UDFs. Need to be investigated. However, it also requires a testing utility to get all of the attempted hosts from the result. This could be probably implemented usingHistoryListener.Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced..github/workflows/build.ymlingtest_filter..github/workflows/cassandra.ymlingtest_filter.