Skip to content

Conversation

@wprzytula
Copy link
Contributor

When cass_future_coordinator was implemented, we forgot to remove it from the limitations section of the README.md file.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • [ ] I have implemented Rust unit tests for the features/changes introduced.
  • [ ] I have enabled appropriate tests in .github/workflows/build.yml in gtest_filter.
  • [ ] I have enabled appropriate tests in .github/workflows/cassandra.yml in gtest_filter.

When `cass_future_coordinator` was implemented, we forgot to remove it
from the limitations section of the README.md file.
@wprzytula wprzytula requested a review from Lorak-mmk June 6, 2025 13:21
@wprzytula wprzytula self-assigned this Jun 6, 2025
@wprzytula wprzytula added the documentation Improvements or additions to documentation label Jun 6, 2025
@wprzytula wprzytula added this to the 0.5 milestone Jun 6, 2025
Comment on lines 116 to 119
the logging level and callback are passed through a custom event subscriber which is globally set as default when `cass_log_set_level` is called.
So, `cass_log_set_level` *must* be called only once as subsequent attempts trying to modify the globally set event subscriber will be ignored.
Also, Rust programs using Cpp-Rust driver under the hood must avoid calling `tracing::subscriber::set_global_default` as this will cause conflicts.
Also, Rust programs using Cpp-Rust driver under the hood must avoid calling `tracing::subscriber::set_global_default` as this will cause conflicts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we verify that this tracing::subscriber::set_global_default issue is actually true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember.

@wprzytula wprzytula merged commit 2e6e992 into scylladb:master Jun 6, 2025
12 checks passed
@wprzytula wprzytula deleted the update-limitations branch June 6, 2025 13:53
@wprzytula wprzytula mentioned this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants