Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data set filled with tombstones #1585

Closed
amnonh opened this issue Nov 9, 2021 · 9 comments · Fixed by #1618
Closed

Data set filled with tombstones #1585

amnonh opened this issue Nov 9, 2021 · 9 comments · Fixed by #1618

Comments

@amnonh
Copy link
Collaborator

amnonh commented Nov 9, 2021

Describe the issue logically
Alot of tombestones makes reads slow

Describe the condition when the issue happens
No good indication

What the user should do when this happens
Change compaction strategy.
run a major compaction
Any Other info or Links.

@amnonh amnonh added the advisor label Nov 9, 2021
@slivne
Copy link

slivne commented Nov 21, 2021

@bhalevy / @cmm - amnon can add an indication to monitoring on range tombstones / tombstones - we are intrested mainly in the amount that are hit during reads

I kmow we added some metrics (I hope they are merged) can you please point out the metrics and the releases that have those metrics.

@amnonh
Copy link
Collaborator Author

amnonh commented Nov 23, 2021

@cmm
Copy link

cmm commented Nov 28, 2021

the *_tombstone_reads metrics there seem to be what you want here, yes. they should have been back-ported to 21.1, if I understand correctly

@slivne
Copy link

slivne commented Dec 5, 2021

Detailed:

  • add a graph for cache tombstones
  • add a graph for tombstones for sstables

Advisor - add a warning - use a ratio between number of tombstones to number of reads - if the ratio is > 10 indicate the user should check the data model

@amnonh
Copy link
Collaborator Author

amnonh commented Dec 5, 2021

Add enable probabilistic tracing and slow query tracing

@amnonh
Copy link
Collaborator Author

amnonh commented Dec 5, 2021

@bhalevy I didn't see the metrics in 4.5, do I need to do somthing for it to appear?

@bhalevy
Copy link
Member

bhalevy commented Dec 6, 2021

@bhalevy I didn't see the metrics in 4.5, do I need to do somthing for it to appear?

@amnonh they are available only since 4.6 (and backported to 2021.1)

@amnonh
Copy link
Collaborator Author

amnonh commented Jan 13, 2022

@bhalevy I want to create some graphs for the release notes, can you explain how can I test it?

@bhalevy
Copy link
Member

bhalevy commented Jan 13, 2022

@bhalevy I want to create some graphs for the release notes, can you explain how can I test it?

I think a good test will be:

  • Setup
    • set gc_grace_seconds to a small number
    • disable auto_compaction
  • Insert data
    • flush
  • do a bunch of range deletions
    • at this point the graph should show them
    • flush, so to generate tombstones in the sstables
  • run repair (in master, since tombstone purging now depends on successful repair)
  • run major compaction
  • See that the tombstones were purged and went away

@raphaelsc @asias please confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants