Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring 3.9.x - Allow toggling tooltip selects #1609

Closed
fee-mendes opened this issue Nov 29, 2021 · 0 comments · Fixed by #1612
Closed

Monitoring 3.9.x - Allow toggling tooltip selects #1609

fee-mendes opened this issue Nov 29, 2021 · 0 comments · Fixed by #1612
Labels
enhancement New feature or request

Comments

@fee-mendes
Copy link
Member

System information

  • Scylla version (you are using): 2021.1.7
  • Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
It looks like that starting with Scylla Monitoring 3.9.x the tooltip selector defaults to single rather than all. This was the default set-up as of <3.8.x. It isn't clear whether this was an intended change or whether this was caused by the upgrade to Grafana 8.

The only workaround I know for now is to update all Grafana JSONs to specify multi rather than single within the tooltip selector, as the following one-liner:

find . -type f -exec sed -i 's/"mode": "single"/"mode": "multi"/g' {} \;

Is it possible to add a toggler? I believe that a single tooltip selector has its own added value, but we can't remove the multi selector altogether without having a way to switch back to it eventually.

Who will benefit with this feature?
Allowing to toggle between different tooltip selectors will help to support a variety of use cases. In case this is not possible, multi should be the default as:

  • Users are already used to it
  • Analyzing cross-node/cross-shard metrics may become problematic

cc @amnonh

@fee-mendes fee-mendes added the enhancement New feature or request label Nov 29, 2021
@amnonh amnonh added this to the Monitoring 3.10 milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants