Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hints manager sent annotation, uses the wrong metric #2250

Closed
ViperRu opened this issue Apr 2, 2024 · 2 comments · Fixed by #2260
Closed

Hints manager sent annotation, uses the wrong metric #2250

ViperRu opened this issue Apr 2, 2024 · 2 comments · Fixed by #2260
Labels
bug Something isn't working right

Comments

@ViperRu
Copy link

ViperRu commented Apr 2, 2024

"expr":"changes(scylla_hints_manager_written{cluster=\"$cluster\"}[$__rate_interval])>0",

Please correct to "scylla_hints_manager_sent"

@ViperRu
Copy link
Author

ViperRu commented Apr 8, 2024

But those seem to be two different metrics: https://github.com/scylladb/scylladb/blob/8550a38a8baab074a1b1b5f66ad321c9c5d669d9/db/hints/manager.cc#L151 https://github.com/scylladb/scylladb/blob/8550a38a8baab074a1b1b5f66ad321c9c5d669d9/db/hints/manager.cc#L160

Just now scylla_hints_manager_written is used both for the annotation_hints_sent and for the annotation_hints_writes.

@amnonh amnonh added this to the Monitoring 4.7.1 milestone Apr 14, 2024
@amnonh amnonh changed the title Editing the metric name Hints manager sent annotation, uses the wrong metric Apr 16, 2024
@amnonh amnonh added the bug Something isn't working right label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants