Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query_paged is a misleading name #940

Closed
Lorak-mmk opened this issue Feb 23, 2024 · 1 comment · Fixed by #1061
Closed

query_paged is a misleading name #940

Lorak-mmk opened this issue Feb 23, 2024 · 1 comment · Fixed by #1061
Assignees
Labels
API-breaking This might introduce incompatible API changes good first issue Good for newcomers QoL Quality of Life enhancements
Milestone

Comments

@Lorak-mmk
Copy link
Collaborator

query_paged suggests that the executed query will be paged, while this is not the case.
Whether the query is paged or not is controlled by querie's page_size attribute.
The only difference between query and query_paged is that the former accepts custom paging_state, so something like query_with_paging_state would probably be a better name.

@Lorak-mmk Lorak-mmk added good first issue Good for newcomers API-breaking This might introduce incompatible API changes labels Feb 23, 2024
@roydahan
Copy link
Collaborator

roydahan commented Jun 3, 2024

@wprzytula I see this one is in "High Priority" but it doesn't have a milestone.
Is it planned to pre-1.0 milestones?

@wprzytula wprzytula added this to the 0.15.0 milestone Jun 4, 2024
@wprzytula wprzytula added the QoL Quality of Life enhancements label Jul 9, 2024
@wprzytula wprzytula assigned wprzytula and unassigned muzarski and Lorak-mmk Aug 13, 2024
@dkropachev dkropachev modified the milestones: 0.16.0, 0.14.0 Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-breaking This might introduce incompatible API changes good first issue Good for newcomers QoL Quality of Life enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants