New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lw_shared_ptr UB in ::release #2358

Open

kelbon opened this issue Jul 22, 2024 · 0 comments

kelbon commented Jul 22, 2024

This code does not check if 'p' is not nullptr

    std::unique_ptr<T, disposer> release() noexcept {
        auto p = std::exchange(_p, nullptr);
        if (--p->_count) {

So it is UB:

#include <seastar/core/shared_ptr.hh>

int main() {
    seastar::lw_shared_ptr<int> p = nullptr;
    auto x = p.release();
}

https://godbolt.org/z/ve5YWWf5a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment