Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyTorch CUDA version in environment_gpu.yml is out of date #341

Closed
sdatkinson opened this issue Nov 10, 2023 · 3 comments · Fixed by #342
Closed

PyTorch CUDA version in environment_gpu.yml is out of date #341

sdatkinson opened this issue Nov 10, 2023 · 3 comments · Fixed by #342
Labels
enhancement New feature or request priority:low Low-priority issues

Comments

@sdatkinson
Copy link
Owner

CUDA 11.7 is no longer a recommended version by PyTorch; 11.8 is the "old version" now:
image

Let's bump up to 12.1!

This may require people to update their drivers, and it'll be worth having some hints in the environment_gpu.ymnl and README.md.

I may also need to update the installation video.
@sdatkinson sdatkinson added enhancement New feature or request priority:low Low-priority issues labels Nov 10, 2023
@sdatkinson sdatkinson mentioned this issue Nov 10, 2023
Merged
@hmollercl
Copy link
Contributor

This shoud be also change here: https://neural-amp-modeler.readthedocs.io/en/latest/installation.html which I assume comes from here

neural-amp-modeler/docs/source/installation.rst

Line 14 in d04fa0c

$ conda install -y pytorch pytorch-cuda=11.8 -c pytorch -c nvidia

@sdatkinson
Copy link
Owner Author

@hmollercl feel free to PR me 👍🏻

@hmollercl
Copy link
Contributor

#478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority:low Low-priority issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update PyTorch CUDA version to 12.1 sdatkinson/neural-amp-modeler
2 participants
@sdatkinson @hmollercl