Fix the computation of total seconds with years and months #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdispater
force-pushed
the
fix-total-seconds-computation-with-years-and-months
branch
from
4ab7fb4 to
9274f5c
Compare
sdispater
force-pushed
the
fix-total-seconds-computation-with-years-and-months
branch
from
9274f5c to
834ff81
Compare
Merged
|
This commit breaks the following: >>> dt = pendulum.DateTime(2022, 6, 8, 13, 21, 12, 239829, tzinfo=pendulum._Timezone('America/New_York'))
>>> dt._add_timedelta(datetime.timedelta(seconds=3600))
DateTime(2022, 6, 8, 14, 21, 12, 239829, tzinfo=Timezone('America/New_York'))The _add_timedelta call is a no-op. |
Closed
|
The problem is it's calling pendulum.Date.add_timedelta instead of pendulum.DateTime.add_timedelta, even though it's a DateTime object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #479
Resolves #475
Pull Request Check List