Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename period to interval in repr and tests #757

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

Benji19967
Copy link
Contributor

Hi @sdispater @Secrus!

This PR renames the remaining mentions of period/Period to interval/Interval, where it makes sense.

  • Rename Period to Interval in
    • Interval.__repr__
    • ValueError message of Interval.__new__
    • docstrings of some methods in Interval
  • Rename period to interval (mostly in tests) for a more consistent codebase. I left the docs untouched.

A quick rg search will show the only mentions left of period/Period are in docs/, formatting/, locales/, CHANGELOG.md or clock

PS: Thanks for the great library! I have relied on it a lot, both for professional and personal projects.
PPS: I have some free time on my hands in the next couple of months and would happily contribute more, if you guys have any suggestions.

Pull Request Check List

  • Added Updated tests for changed code.
  • Updated documentation for changed code.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 2, 2023

CodSpeed Performance Report

Merging #757 will degrade performances by 19.12%

Comparing Benji19967:master (997999a) with master (18f9c0e)

Summary

❌ 1 regressions
✅ 1 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master Benji19967:master Change
test_format 2.3 ms 2.8 ms -19.12%

@Secrus Secrus merged commit 4abc087 into python-pendulum:master Oct 24, 2023
17 checks passed
@sdispater sdispater mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants