fix: rename period to interval in repr and tests #757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sdispater @Secrus!
This PR renames the remaining mentions of
period
/Period
tointerval
/Interval
, where it makes sense.Period
toInterval
inInterval.__repr__
ValueError
message ofInterval.__new__
Interval
period
tointerval
(mostly in tests) for a more consistent codebase. I left thedocs
untouched.A quick
rg
search will show the only mentions left ofperiod
/Period
are indocs/
,formatting/
,locales/
,CHANGELOG.md
orclock
PS: Thanks for the great library! I have relied on it a lot, both for professional and personal projects.
PPS: I have some free time on my hands in the next couple of months and would happily contribute more, if you guys have any suggestions.
Pull Request Check List
AddedUpdated tests for changed code.