Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TOML 1.0.0 compliance #102

Merged
merged 5 commits into from
Jul 31, 2020
Merged

Fix TOML 1.0.0 compliance #102

merged 5 commits into from
Jul 31, 2020

Conversation

sdispater
Copy link
Member

This PR fixes tricky and edge cases to ensure full compliance with TOML 1.0.0.

Most of the test cases come from https://github.com/iarna/toml-spec-tests which has a comprehensive test suite.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020

Codecov Report

Merging #102 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   91.91%   91.80%   -0.12%     
==========================================
  Files          10       11       +1     
  Lines        2276     2391     +115     
==========================================
+ Hits         2092     2195     +103     
- Misses        184      196      +12     
Impacted Files Coverage Δ
tomlkit/exceptions.py 93.02% <0.00%> (-1.85%) ⬇️
tomlkit/container.py 86.46% <0.00%> (-1.52%) ⬇️
tomlkit/items.py 88.14% <0.00%> (-0.27%) ⬇️
tomlkit/__init__.py 100.00% <0.00%> (ø)
tomlkit/_utils.py 97.61% <0.00%> (+0.28%) ⬆️
tomlkit/parser.py 96.53% <0.00%> (+0.37%) ⬆️
tomlkit/source.py 95.45% <0.00%> (+0.90%) ⬆️
tomlkit/toml_char.py 94.28% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c0809...157f550. Read the comment docs.

@sdispater sdispater merged commit 3e6a2a7 into master Jul 31, 2020
@sdispater sdispater deleted the ensure-specs-following branch July 31, 2020 08:02
@sdispater sdispater mentioned this pull request Jul 31, 2020
capuanob pushed a commit to capuanob/tomlkit that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants