Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from error-chain to failure for error handling #5

Open
sdleffler opened this issue Feb 7, 2018 · 0 comments
Open

Switch from error-chain to failure for error handling #5

sdleffler opened this issue Feb 7, 2018 · 0 comments

Comments

@sdleffler
Copy link
Owner

While working on Attaca I've been using the failure crate for error handling; for various reasons, it's vastly superior to the error-chain crate. Having to integrate error-chain with failure is proving to be problematic, because failure follows the philosophy that errors should be Send + Sync while error-chain maintains simply Send; this results in stuff like the failure::SyncFailure wrapper which puts a non-Sync error into a Mutex to make things safe. This is not cool and should be fixed. Migrating shouldn't be very difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant