Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command not executed #579

Closed
damien-biasotto opened this issue May 17, 2018 · 2 comments
Closed

Command not executed #579

damien-biasotto opened this issue May 17, 2018 · 2 comments
Labels

Comments

@damien-biasotto
Copy link
Contributor

So first of all, very nice tool :)

This issue is regarding an upcoming PR, I'm trying to create a hook for PHP-Cs-Fixer :

Before I submit that pull-request, I tried it on one of my project. Somehow the hook says everything is fine, but the file was not touched.

If I run the same command manually, the file is updated. I'm not sure how to debug that (I'm brand new in the ruby world). and what I'm doing wrong and I could use your help.

@sds
Copy link
Owner

sds commented May 17, 2018

Hey @damien-biasotto, glad you're finding value with the tool.

Overcommit does not yet support pre-commit hooks with file-changing side effects. See #238 for details. Hope that explains what you're observing!

@sds sds closed this as completed May 17, 2018
@damien-biasotto
Copy link
Contributor Author

Ah indeed that makes sense :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants