Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling NaN's #35

Closed
fealho opened this issue Sep 15, 2021 · 0 comments · Fixed by #30
Closed

Handling NaN's #35

fealho opened this issue Sep 15, 2021 · 0 comments · Fixed by #30
Assignees
Labels
bug Something isn't working
Milestone

Comments

@fealho
Copy link
Member

fealho commented Sep 15, 2021

DeepEcho 0.2.0 cannot handle NaN's. This means that if SDV passes a NaN value to DeepEcho, the current code crashes.

The snippet below reproduces this issue:

sequences = [
    {
        'context': [],
        'data': [
            [0.0, np.nan, 1.0],
            [0.5, 0.4, 1.0],
        ]
    }
]
context_types = []
data_types = ['continuous', 'continuous']

model = PARModel()
model.fit_sequences(sequences, context_types, data_types)
model.sample_sequence([])
@fealho fealho added the bug Something isn't working label Sep 15, 2021
@fealho fealho mentioned this issue Sep 15, 2021
@katxiao katxiao added this to the v0.2.1 milestone Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants