Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove anyio usage #252

Closed
amontanez24 opened this issue Jun 14, 2023 · 0 comments · Fixed by #259
Closed

Remove anyio usage #252

amontanez24 opened this issue Jun 14, 2023 · 0 comments · Fixed by #259
Assignees
@lajohn4747
Labels
maintenance Tasks related to infrastructure & dependencies
Milestone
0.8.0

Comments

@amontanez24
Copy link
Contributor

Problem Description

We don't need to use the async version of Path here, we can just use the Pathlib one.

SDGym/sdgym/cli/utils.py

Line 7 in 5c15bb6

from anyio import Path

Expected behavior

  • Remove anyio import
@amontanez24 amontanez24 added the maintenance Tasks related to infrastructure & dependencies label Jun 14, 2023
@lajohn4747 lajohn4747 mentioned this issue Oct 10, 2023
Merged
@lajohn4747 lajohn4747 self-assigned this Oct 10, 2023
@amontanez24 amontanez24 added this to the 0.7.1 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lajohn4747 lajohn4747

Labels
maintenance Tasks related to infrastructure & dependencies
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Remove unneeded import from anyio and fix type for docs sdv-dev/SDGym
2 participants
@amontanez24 @lajohn4747