Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add load_from_dict to SingleTableMetadata and MultiTableMetadata #1314

Closed
npatki opened this issue Mar 16, 2023 · 0 comments
Closed

Add load_from_dict to SingleTableMetadata and MultiTableMetadata #1314

npatki opened this issue Mar 16, 2023 · 0 comments
Assignees
@amontanez24
Labels
feature request Request for a new feature
Milestone
1.0.0

Comments

@npatki
Copy link
Contributor

npatki commented Mar 16, 2023

It's strange that we can convert these to_dict() but we can't load them from dict.

These class methods should accept a Python dictionary and convert it to an object.

metadata = SingleTableMetadata.load_from_dict(
    metadata_dict=my_python_dictionary
)
metadata = MultiTableMetadata.load_from_dict(
    metadata_dict=my_python_dictionary
)
@npatki npatki added feature request Request for a new feature new Automatic label applied to new issues and removed new Automatic label applied to new issues labels Mar 16, 2023
@amontanez24 amontanez24 added this to the 1.0.0 milestone Mar 16, 2023
@amontanez24 amontanez24 mentioned this issue Mar 16, 2023
Merged
@amontanez24 amontanez24 self-assigned this Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amontanez24 amontanez24

Labels
feature request Request for a new feature
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@npatki @amontanez24