Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HMA use hierarchical sampling mixin #1428

Closed
amontanez24 opened this issue May 15, 2023 · 0 comments · Fixed by #1449
Closed

Make HMA use hierarchical sampling mixin #1428

amontanez24 opened this issue May 15, 2023 · 0 comments · Fixed by #1449
Assignees
@frances-h
Labels
feature:sampling Related to generating synthetic data after a model is built internal The issue doesn't change the API or functionality
Milestone
1.2.1

Comments

@amontanez24
Copy link
Contributor

Problem Description

As an engineer, it would be helpful to have our synthesizers follow clear and well defined abstractions for the sake of modifying or enhancing functionality.

Expected behavior

Additional context

  • All changes should be private. There shouldn't be a need to alter any user facing methods or classes.
@amontanez24 amontanez24 added the feature:sampling Related to generating synthetic data after a model is built label May 15, 2023
@frances-h frances-h mentioned this issue May 31, 2023
Merged
@amontanez24 amontanez24 added this to the 1.2.1 milestone Jun 29, 2023
@amontanez24 amontanez24 added the internal The issue doesn't change the API or functionality label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frances-h frances-h

Labels
feature:sampling Related to generating synthetic data after a model is built internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
1.2.1
Development

Successfully merging a pull request may close this issue.

Use HierarchicalSampler mixin with HMA sdv-dev/SDV
2 participants
@amontanez24 @frances-h