Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During fit, there is a FutureWarning (due to RDT 1.5.0) #1456

Closed
npatki opened this issue Jun 2, 2023 · 0 comments · Fixed by #1463
Closed

During fit, there is a FutureWarning (due to RDT 1.5.0) #1456

npatki opened this issue Jun 2, 2023 · 0 comments · Fixed by #1463
Labels
bug Something isn't working maintenance Tasks related to infrastructure & dependencies
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Jun 2, 2023

Environment Details

  • SDV version: 1.1.0
  • RDT version: 1.5.0

Error Description

The latest version of RDT (1.5.0) has deprecated the parameter model_missing_values and is instead using a new parameter missing_value_generation.

In the latest version of SDV (1.1.0), we are using the older parameter name somewhere in the code, so there is a FutureWarning being thrown out.

Steps to reproduce

Install latest versions of SDV and RDT libraries

%pip install rdt==1.5.0
%pip install sdv==1.1.0

Run the demo code

from sdv.datasets.demo import download_demo
from sdv.single_table import GaussianCopulaSynthesizer

data, metadata = download_demo(
    modality='single_table',
    dataset_name='fake_hotel_guests'
)

synthesizer = GaussianCopulaSynthesizer(metadata)
synthesizer.fit(data)

Observe the warning

/usr/local/lib/python3.10/dist-packages/rdt/transformers/base.py:132: FutureWarning: Future versions of RDT 
will not support the 'model_missing_values' parameter. Please switch to using the 'missing_value_generation' 
parameter to select your strategy.
  warnings.warn(
@npatki npatki added bug Something isn't working maintenance Tasks related to infrastructure & dependencies labels Jun 2, 2023
@amontanez24 amontanez24 added this to the 1.2.0 milestone Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Tasks related to infrastructure & dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants