Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random_state arguments wherever relevant #586

Open
csala opened this issue Sep 9, 2021 · 1 comment
Open

Add random_state arguments wherever relevant #586

csala opened this issue Sep 9, 2021 · 1 comment
Labels
feature request Request for a new feature

Comments

@csala
Copy link
Contributor

csala commented Sep 9, 2021

There have been a few questions, such as #515 and #299 about how to set a random state for the models.
External workarounds exist, like the one shared in those questions, but we may want to add random_state arguments that take care of doing this internally.

The arguments should be added in all the places where it makes sense doing so, such as the __init__, fit and sample methods of the models, or any other steps that involve any kind of randomness, such as the Constraints or the RDT transformers.

@csala csala added feature request Request for a new feature needs discussion labels Sep 9, 2021
@npatki
Copy link
Contributor

npatki commented Jul 7, 2022

Note that as of SDV 0.15.0, all single-table sampling functions now have a randomize_samples parameter to control the randomness.

Remaining places to control randomness are:

  • Multi-table sampling functions
  • Sequential model sampling functions
  • All fitting functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants