Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tabular preset docs #777

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Add tabular preset docs #777

merged 1 commit into from
Apr 29, 2022

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Apr 28, 2022 •
edited
Loading

Add tabular preset user guide documentation

image

image

@katxiao katxiao requested a review from a team as a code owner April 28, 2022 00:44
@katxiao katxiao requested review from fealho and removed request for a team April 28, 2022 00:44
@katxiao katxiao force-pushed the tabular-preset-docs branch from f5417eb to 74b7bdd Compare April 28, 2022 00:45
@katxiao katxiao force-pushed the tabular-preset-docs branch from 74b7bdd to 273eec4 Compare April 28, 2022 17:09
@codecov-commenter
Copy link

Codecov Report

Merging #777 (f5417eb) into master (00238f1) will not change coverage.
The diff coverage is n/a.

❗ Current head f5417eb differs from pull request most recent head 273eec4. Consider uploading reports for the commit 273eec4 to get more accurate results

@@           Coverage Diff           @@
##           master     #777   +/-   ##
=======================================
  Coverage   67.89%   67.89%           
=======================================
  Files          38       38           
  Lines        2869     2869           
=======================================
  Hits         1948     1948           
  Misses        921      921
Impacted Files Coverage Δ
sdv/lite/tabular.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00238f1...273eec4. Read the comment docs.

fealho
fealho approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@katxiao katxiao merged commit 81b2df6 into master Apr 29, 2022
@katxiao katxiao deleted the tabular-preset-docs branch April 29, 2022 15:08
@katxiao katxiao added this to the 0.14.1 milestone May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fealho fealho fealho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.
3 participants
@katxiao @codecov-commenter @fealho