Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom constraints documentation #857

Merged
merged 6 commits into from
Jul 6, 2022

Conversation

pvk-developer
Copy link
Member

@pvk-developer pvk-developer commented Jul 1, 2022

Custom Constraints documentation update.
build_html_user_guides_single_table_custom_constraints html

@pvk-developer pvk-developer requested a review from a team as a code owner July 1, 2022 13:45
@pvk-developer pvk-developer requested review from fealho, amontanez24 and npatki and removed request for a team July 1, 2022 13:45
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me :shipit:

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #857 (a3cd335) into master (0f88065) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
+ Coverage   68.14%   68.18%   +0.04%     
==========================================
  Files          38       38              
  Lines        2872     2876       +4     
==========================================
+ Hits         1957     1961       +4     
  Misses        915      915              
Impacted Files Coverage Δ
sdv/constraints/tabular.py 99.73% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f88065...a3cd335. Read the comment docs.

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pvk-developer pvk-developer merged commit 6be32ff into master Jul 6, 2022
@pvk-developer pvk-developer deleted the update-custom-constraints-documentation branch July 6, 2022 09:29
@pvk-developer pvk-developer added this to the 0.16.0 milestone Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants