Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabularPreset doesn't support new sampling parameters #887

Closed
npatki opened this issue Jul 8, 2022 · 0 comments · Fixed by #903
Closed

TabularPreset doesn't support new sampling parameters #887

npatki opened this issue Jul 8, 2022 · 0 comments · Fixed by #903
Labels
bug Something isn't working data:single-table Related to tabular datasets feature:sampling Related to generating synthetic data after a model is built
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Jul 8, 2022

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDV version: 0.16.0.dev1

Error Description

When I create a TabularPreset model the sampling method parameters don't behave as expected:

  • max_tries_per_batch cannot be used on any of the methods
  • batch_size cannot be used on sample_conditions or sample_remaining_columns (although it works on the generic sample method)

Additional Notes

@npatki npatki added bug Something isn't working data:single-table Related to tabular datasets feature:sampling Related to generating synthetic data after a model is built new Automatic label applied to new issues labels Jul 8, 2022
@npatki npatki changed the title TabularPrest doesn't support new sampling parameters TabularPreset doesn't support new sampling parameters Jul 8, 2022
@npatki npatki removed the new Automatic label applied to new issues label Jul 8, 2022
@pvk-developer pvk-developer added this to the 0.16.0 milestone Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data:single-table Related to tabular datasets feature:sampling Related to generating synthetic data after a model is built
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants